Fix #1753: Better comparison of path types #1760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case, a path went through a type parameter which was aliased to a singleton type. Need to dealias to get to the special case handling two paths.
odersky
changed the title
felixmulder
approved these changes
Nov 30, 2016
| import bTypes._ | ||
| val b: BTypesFromSymbols[int.type] = bTypes | ||
| val x: int.type = bTypes.int | ||
| val y: bTypes.int.type = int |
There was a problem hiding this comment.
What are these two lines with x and y?
Used it for debugging?
There was a problem hiding this comment.
Break the problem apart into two subtype tests. I thought it was good to add this.
| isSubType(tp1, tp2i) // see z1720.scala for a case where this can arise even in typer. | ||
| isSubType(tp1, tp2i) | ||
| // see z1720.scala for a case where this can arise even in typer. | ||
| // Also, i1753.scala, to show why the dealias above is necessary. |
There was a problem hiding this comment.
strange indentation here?
There was a problem hiding this comment.
I use this style on occasion. Basically, if an end of line comment is too long I put several
indented lines after the commented statement. I find it sometimes clearer than having the comments before (depends on the wording of the comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case, a path went through a type parameter which was
aliased to a singleton type. Need to dealias to get to the
special case handling two paths.
Review by @felixmulder