Skip to content

docs: minor fix in package object doc #17521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

road21
Copy link
Contributor

@road21 road21 commented May 16, 2023

Package objects are still available in scala 3.2 (and will be available in 3.3), so no need to write versions explicitly.

@WojciechMazur
Copy link
Contributor

You need to sign the CLA before merging this PR. You can find more info here: https://dotty.epfl.ch/docs/contributing/getting-started.html

@som-snytt
Copy link
Contributor

I don't understand why they aren't already deprecated.

Also, when they are deprecated, will this syntax be deprecated, object named package (from an arbitrary test snippet):

package p {
  object `package` {
    def run() = ()
  }
  class C {
    def apply() = run()
  }
}
package q {
  import p.`package`.*
  class D {
    def apply() = run()
  }
  object Thing {
    object `package` {
      def run() = ()
    }
  }
}

@road21
Copy link
Contributor Author

road21 commented May 22, 2023

You need to sign the CLA before merging this PR. You can find more info here: https://dotty.epfl.ch/docs/contributing/getting-started.html

I have signed, but I am unable to rerun pipeline

@nicolasstucki
Copy link
Contributor

I don't understand why they aren't already deprecated.

It is to keep 3.3.0 LTS as compatible as possible with Scala 2. We will start deprecating more things after in 3.4+.

@nicolasstucki nicolasstucki merged commit 2712dde into scala:main Jul 13, 2023
Kordyjan added a commit that referenced this pull request Dec 8, 2023
Backports #17521 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@Kordyjan Kordyjan added this to the 3.3.2 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants