fix #1748: desugaring with StringContext in PatDef #1749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixmulder
reviewed
Nov 28, 2016
| println(name) | ||
| println(parent) | ||
| } | ||
| } |
There was a problem hiding this comment.
Perhaps this should be a run-test instead since you're printing things? :)
There was a problem hiding this comment.
Yes, I agree, it's better to be able to actually run it.
|
Check file not correct? |
|
Let me try adding a newline at the end of the check file. |
liufengyun
force-pushed
the
fix-i1748
branch
from
029dbdc to
98001ec
Compare
liufengyun
force-pushed
the
fix-i1748
branch
from
98001ec to
8f3301e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1748: desugaring with StringContext in PatDef
The method
getVariablesforgets the caseThicket.Review @felixmulder