-
Notifications
You must be signed in to change notification settings - Fork 1.1k
test: add in regression test for #7445 #17475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We should also include the original example as a regression test. type O1[A] = {
type OutInner[Ts] <: Tuple = Ts match {
case Unit => Unit
case h *: t => h *: OutInner[t]
}
type Out = OutInner[A]
}
def f1: O1[(Int, Int)]#Out = ??? |
Huh, actually trying out the originally report produces a different error than the original report is about.
To be honest, i'm not 100% sure on the intended behavior here. Is this indeed illustrating the original issue, another issue, or should this compile? |
That makes sense. The code should be updated to type O1[A] = {
type OutInner[Ts] <: Tuple = Ts match {
case EmptyTuple => EmptyTuple
case h *: t => h *: OutInner[t]
}
type Out = OutInner[A]
}
def f1: O1[(Int, Int)]#Out = ??? |
Alright, thanks. So this doesn't show the original issue, but it does still fail a test with pickling. I've updated the original description to reflect this and I'll update the original issue as well. |
Nevermind, I realized I should have been using the other |
This adds in a regression test for the minimized issue, but the original one now has a different issue with pickling. I've added this in as well, but added it to the excludes.
So this adds in a test that shows that the minimized version of the original issue is fixed, but the original report now fails the pickling tests. I've gone ahead and added a test for that as well, but added it to the excludes. I'll reopen the issue and mention this update.