-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Retry waiting for javac under Vulpix #17373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If running a single test, the pool shutdown is likely to subvert `waitFor` the javac process. Catch the `InterruptedException` and try again with a timed wait of generous but finite duration, to accommodate testing by developers. This quick fix does not correct the race, which presumably does not matter because of the order in which tests are ordinarily submitted.
05aa3ab
to
0975d29
Compare
Locally, I just saw a couple of interrupted tests while
and
|
According to the javadoc for the ExecutorService, this shouldn't happen. The doc for
Since we call |
If running a single test, the pool shutdown
is likely to subvert
waitFor
the javac process.Catch the
InterruptedException
and try againwith a timed wait of generous but finite duration,
to accommodate testing by developers. This quick
fix does not correct the race, which presumably
does not matter because of the order in which tests
are ordinarily submitted.
For example,
tests/pos-java-interop/t2940
: