Add test for issue #17231 #17300
Merged
Add test for issue #17231 #17300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,2 @@ | |||
| scala> summon[ValueOf["a"]] | |||
| val res0: ValueOf["a"] = scala.ValueOf@61 | |||
There was a problem hiding this comment.
This toString uses the hash. This test will not be stable.
There was a problem hiding this comment.
Oh, I looked at the neighboring i15493 which also had hashes, so I assumed it would be fine
There was a problem hiding this comment.
How do you advise I proceed ?
There was a problem hiding this comment.
The hash of ValueOf is of its underlying type, String, which is of the content. "a" is hex 0x61, which isn't going to change. So this is fine.
dwijnand
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.