Add optimization to reduce extra iterations of the safe init checker. #17057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
reviewed
Mar 7, 2023
| @@ -99,7 +105,9 @@ class Cache[Config, Res]: | |||
| */ | |||
| def cachedEval(config: Config, expr: Tree, cacheResult: Boolean, default: Res)(eval: Tree => Res): Res = | |||
| this.get(config, expr) match | |||
| case Some(value) => value | |||
| case Some(value) => | |||
| cacheUsed = true | |||
There was a problem hiding this comment.
For the init checker, if we read from global cache, we can think it's still not used. Maybe move it to the method get:
def get(config: Config, expr: Tree): Option[Res] =
val res = current.get(config, expr)
cacheUsed = cacheUsed || res.nonEmpty
res
liufengyun
approved these changes
Mar 7, 2023
| /** Whether any value in the cache was accessed after being added. | ||
| * If no cached values are used after they are added for the first time | ||
| * then another iteration of analysis is not needed. | ||
| */ |
There was a problem hiding this comment.
Consider make it more precise in the comment: Whether any value in the output cache (this.current).
Minor: the comment * is not aligned.
olhotak
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the cache is never accessed on a certain iteration of safe initializing checking for a class, then another iteration is not needed. Implementing this optimization and compiling Dotty, we observe the following improvements:
From 4158 total iterations to 4004.
From 460 extra iterations to 306.
Running the initialization tests in
tests/initwe have the following improvements:From 790 total iterations to 708.
From 139 extra iterations to 57.