Skip to content

Fix use of accessibleFrom when finding default arg getters #16977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Fix use of accessibleFrom when finding default arg getters #16977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/typer/Applications.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ object Applications {
else
def selectGetter(qual: Tree): Tree =
val getterDenot = qual.tpe.member(getterName)
.accessibleFrom(qual.tpe.widenIfUnstable) // to reset Local
.accessibleFrom(qual.tpe.widenIfUnstable, superAccess = true) // to reset Local
if (getterDenot.exists) qual.select(TermRef(qual.tpe, getterName, getterDenot))
else EmptyTree
if !meth.isClassConstructor then
Expand Down
2 changes: 2 additions & 0 deletions tests/pos/i16814.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
class Foo protected (foo: Int = 0) { }
class Bar extends Foo