Fix #1662: Add missing case for singleton #1695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have to handle also SkolemTypes there. Fixes scala#1662.
liufengyun
reviewed
Nov 11, 2016
| @@ -343,6 +343,7 @@ object tpd extends Trees.Instance[Type] with TypedTreeInfo { | |||
| def singleton(tp: Type)(implicit ctx: Context): Tree = tp match { | |||
| case tp: TermRef => ref(tp) | |||
| case tp: ThisType => This(tp.cls) | |||
| case tp: SkolemType => singleton(tp.narrow) | |||
| case SuperType(qual, _) => singleton(qual) | |||
There was a problem hiding this comment.
I thought SkolemType is only used for existential types, but it seems not to be the case. Could you briefly explain a little bit the usage of SkolemType, or add a comment to class SkolemType?
RecThis is also a SingletonType, I guess it can be safely ignored here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review by @liufengyun