Apply class-shadowing.md to the Spec
#16839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
requested changes
Feb 6, 2023
Sporarum
force-pushed
the
class-shadowing-apply
branch
from
a46aab1 to
420e02d
Compare
bishabosha
approved these changes
Feb 6, 2023
sjrd
force-pushed
the
class-shadowing-apply
branch
from
420e02d to
c4a2532
Compare
|
Rebased so that a single commit shows up in this PR. |
sjrd
approved these changes
Feb 6, 2023
bishabosha
force-pushed
the
class-shadowing-apply
branch
from
c4a2532 to
03e3bd4
Compare
sjrd
added a commit
that referenced
this pull request
May 1, 2023
This is the rest of the work I (Sporarum) did on the Spec about feature removals. It is not in individual PRs, but still follows the other principles outlined in #16839 and in `docs/_spec/README.md`.
odersky
added a commit
that referenced
this pull request
Jun 20, 2023
…17942) [skip ci] Note that weak conformance was not entirely dropped. It is still applicable to determine *compatibility* of a method call argument to the parameter type. See #7708. @odersky Since you asked about it in the big type system PR. ;) FYI the changes in `TODOreference` and `APPLIEDreference` are part of [our process to integrate the Reference into the Spec](#16839).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR of porting the Scala 2 Specification (the spec) to include the changes of Scala 3, it aims to serve as an example of what a contribution to the porting of spec should look like
Atomic changes should be contained in commits called
Apply <name>.md, where<name>.mdis the name of a file contained in one of the subfolders ofTODOreference, and the content of the commit should be:<name>.md(in this case
05-classes-and-objects.md, but could be multiple files)<name>.mdfrom a subfolder ofTODOreferenceto the corresponding subfolder ofAPPLIEDreference(in this case
class-shadowing.md)<name>.mdto remove all "spec-y" details, potentially deleting the whole file (e.g. if the only useful content in the file was extracted to the Spec)(in this case
class-shadowing-spec.md. Note that<name>-spec.mdfiles should not be deleted just on principle !)Commits that do not adhere to this format are allowed, if they fix something that was already applied
(In the case an important difference with Scala 2 is not present in the reference, it is better to first update the reference, and then change the Spec once that's done)
Please try to obey by the principles outlined in
docs/_spec/README.md, you'll also find there how to build the spec locally.It is preferable for PRs to contain only one commit.
Tips
Once you make a PR with a single commit, it is easier (also for the reviewer!) to incorporate feedback in temporary commits that you
git squashjust before merging than to constantlygit ammend