Skip to content

Fix early returns nested in trace #16753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2023
Merged

Fix early returns nested in trace #16753

merged 1 commit into from
Jan 25, 2023

Conversation

dwijnand
Copy link
Member

Found by enabling the tracing config.

@dwijnand
Fix early returns nested in trace
ee44db8 
Found by enabling the tracing config.
@dwijnand dwijnand force-pushed the fix-trace-local-return branch from d2637d8 to ee44db8 Compare January 23, 2023 15:26
@dwijnand dwijnand marked this pull request as ready for review January 23, 2023 20:35
@dwijnand dwijnand requested a review from liufengyun January 23, 2023 20:35
liufengyun
liufengyun approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwijnand dwijnand merged commit d63e572 into scala:main Jan 25, 2023
@dwijnand dwijnand deleted the fix-trace-local-return branch January 25, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwijnand @liufengyun