Skip to content

Fix -Ytest-pickler bug with private[this] #16538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Fix -Ytest-pickler bug with private[this] #16538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/core/OrderingConstraint.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ class OrderingConstraint(private val boundsMap: ParamBounds,
type This = OrderingConstraint

/** A new constraint with given maps and given set of hard typevars */
def newConstraint( // !!! Dotty problem: Making newConstraint `private` causes -Ytest-pickler failure.
private def newConstraint(
boundsMap: ParamBounds = this.boundsMap,
lowerMap: ParamOrdering = this.lowerMap,
upperMap: ParamOrdering = this.upperMap,
Expand Down
1 change: 1 addition & 0 deletions compiler/src/dotty/tools/dotc/typer/Applications.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@ object Applications {
else
def selectGetter(qual: Tree): Tree =
val getterDenot = qual.tpe.member(getterName)
.accessibleFrom(qual.tpe.widenIfUnstable) // to reset Local
if (getterDenot.exists) qual.select(TermRef(qual.tpe, getterName, getterDenot))
else EmptyTree
if !meth.isClassConstructor then
Expand Down
3 changes: 3 additions & 0 deletions tests/pos/test-pickler-private-this.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
class Test:
def callMeth(test: Test) = test.meth(-1)
private def meth(foo: Int, bar: Int = 1) = foo + bar