Skip to content

Refactor Context #16383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 21, 2022
Merged

Refactor Context #16383

merged 4 commits into from
Nov 21, 2022

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Nov 19, 2022 •
edited
Loading

  • Handle all context state (except caches) in FreshContext.
  • Drop unsused operations
  • Don't have separate classes for NoContext and InitialContext

dwijnand
dwijnand reviewed Nov 19, 2022
View reviewed changes
@odersky
Refactor context
230a5ff 
 - Handle all context state (except caches) in FreshContext.
 - Drop unsused operations
 - Make NoContext a simple val instead of an object
@odersky
More Coontext refactorings
8989957
@odersky
Remove trailing code from previous version
2c52acd
@odersky
Copy changes to test compiler
73ed7f2
@odersky
Copy link
Contributor Author

odersky commented Nov 21, 2022

Going to merge now, since it is a large change set but should be uncontroversial.

@odersky odersky merged commit 2992589 into scala:main Nov 21, 2022
@odersky odersky deleted the refactor-context branch November 21, 2022 10:57
@Kordyjan Kordyjan added this to the 3.3.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@odersky @dwijnand @Kordyjan