Add an option to only rerun tests that have failed #16263
Conversation
G1ng3r
force-pushed
the
wip/rerun-only-failed-tests
branch
5 times, most recently
from
1d8566c to
8417e17
Compare
|
@G1ng3r is this ready for review or are you still making some changes? |
SethTisue
changed the title
|
Hi @prolativ! I think its ready, but not sure. I need someone to approve the solution or give advise on how to improve it. Thanks |
| @@ -30,6 +30,9 @@ object Properties { | |||
| */ | |||
| val testsFilter: List[String] = sys.props.get("dotty.tests.filter").fold(Nil)(_.split(',').toList) | |||
|
|
|||
| /** Run only failed tests */ | |||
There was a problem hiding this comment.
As this pattern starts to repeat, why don't you define a helper method propIsTrue analogous to propIsNullOrTrue and use it here?
| @@ -144,4 +152,15 @@ object TestReporter { | |||
| } | |||
| rep | |||
| } | |||
|
|
|||
| def lastRunFailedTests: List[String] = | |||
There was a problem hiding this comment.
It looks like we make no distinction between the situation when --failed is not enabled and when this option is on but all the tests passed in the previous run. I think we should split these cases, e.g. by returning None in the former case and Some(Nil) in the latter. In general, if all the tests in the previous run passed, I would expect testCompilation --failed to run no tests and give explicit feedback that no tests were run instead of running all the tests.
G1ng3r
force-pushed
the
wip/rerun-only-failed-tests
branch
from
8417e17 to
ca92351
Compare
| Option.when(Properties.rerunFailed)( | ||
| if (failedTestsFile.exists() && failedTestsFile.isFile) | ||
| then java.nio.file.Files.readAllLines(failedTestsFile.toPath).asScala.toList | ||
| else List.empty | ||
| ) |
There was a problem hiding this comment.
| Option.when(Properties.rerunFailed)( | |
| if (failedTestsFile.exists() && failedTestsFile.isFile) | |
| then java.nio.file.Files.readAllLines(failedTestsFile.toPath).asScala.toList | |
| else List.empty | |
| ) | |
| Option.when( | |
| Properties.rerunFailed && | |
| failedTestsFile.exists() && | |
| failedTestsFile.isFile | |
| )(java.nio.file.Files.readAllLines(failedTestsFile.toPath).asScala.toList) |
There was a problem hiding this comment.
The absence of failedTestsFile should also mean that we need to run all the tests
- testCompilation supports running only failed tests with --failed argument
G1ng3r
force-pushed
the
wip/rerun-only-failed-tests
branch
from
ca92351 to
6dfc668
Compare
- testCompilation supports running only failed tests with --failed argument fixes scala#3798
fixes #3798