Add error message for Parsers:1329 #1624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianharko
force-pushed
the
master
branch
from
06b5459 to
ef0d291
Compare
felixmulder
suggested changes
Oct 25, 2016
There was a problem hiding this comment.
Looks great! Break the lines and we're good to go.
Another thing I would actually probably do is move the codeX values into the explanation like this:
val explanation = {
val code1 = ...
val code2 = ...
val code3 = ...
val code4 = ...
hl"""..."""
}since they provide no semantic information that IDEs would be interested in :)
| val code4 = "for i <- 1 to 3 do println(i) // notice the 'do' keyword" | ||
|
|
||
| val explanation = | ||
| hl"""When the enumerators in a for comprehension are not placed in parentheses or braces, a ${"do"} or ${"yield"} statement |
There was a problem hiding this comment.
Could you break this line so that it is max 80 chars long?
| | | ||
| |but the ${"yield"} keyword is still required. | ||
| | | ||
| |For comprehensions that simply perform a side effect without yielding anything can also be written without parentheses |
|
Oh and ping me when the changes have been made - if you guys just update the PR, I don't get notifications about it unfortunately...maybe that's a setting I can change somewher - I'll have a look! cc: @ShaneDelmore, @thiagoandrade6 |
felixmulder
approved these changes
Oct 25, 2016
|
Thanks @sebastianharko ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@felixmulder Error message for Parsers: 1329.