Skip to content

dep: update mill to a stable version in community build #15732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 7, 2022

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Jul 22, 2022

This updates mill to the latest stable release 0.10.5.

@ckipp01
Copy link
Member Author

ckipp01 commented Jul 22, 2022

Pretty much all of these need to be updated in staging:

 - dotty.communitybuild.CommunityBuildTestC.sourcecode
 - dotty.communitybuild.CommunityBuildTestC.pprint
 - dotty.communitybuild.CommunityBuildTestC.requests
 - dotty.communitybuild.CommunityBuildTestC.upickle
 - dotty.communitybuild.CommunityBuildTestC.cask
 - dotty.communitybuild.CommunityBuildTestC.geny
 - dotty.communitybuild.CommunityBuildTestC.fansi
 - dotty.communitybuild.CommunityBuildTestC.oslib
 - dotty.communitybuild.CommunityBuildTestC.ujson
 - dotty.communitybuild.CommunityBuildTestC.utest

@anatoliykmetyuk I see you're mentioned on community build under MAINTENANCE. I talked to @sjrd a bit on Discord about this, but what's the best way to proceed here. Do I really fork every one of these repos in the staging org and then change the submodules to my fork? That seems like a ton of work, and then also that work needs to be repeated on your end to then go and update all the staging repos, and then the submodules again. How can this process be made easier? I'd like to update the docs in the community build section as they seem out of date, but this process seems a bit nonsensical.

@ckipp01 ckipp01 marked this pull request as draft July 22, 2022 12:49
@ckipp01 ckipp01 requested a review from anatoliykmetyuk July 22, 2022 12:52
@anatoliykmetyuk
Copy link
Contributor

I believe your change is enough to change the Mill version everywhere in the CB. Note how mill bootstrap scripts read the environmental variable to obtain the version: https://github.com/dotty-staging/geny/blob/master/mill#L10

@ckipp01
Copy link
Member Author

ckipp01 commented Aug 12, 2022

I believe your change is enough to change the Mill version everywhere in the CB. Note how mill bootstrap scripts read the environmental variable to obtain the version: https://github.com/dotty-staging/geny/blob/master/mill#L10

Thanks for the approval, but I was actually looking for some insight on the questions I asked up above, mainly about the best way to proceed with these type of prs. Right now it seems the only way to update things in the community build is to ping someone on Discord hoping they see your message and sync the community repo. Moving forward, how can we make this more sustainable. It's unrealistic to expect people to do this.

Also I know this is approved, but don't merge this yet. I still have one more PR that needs to be merged in cask, and then all the repos I mentioned have been updated, and then they all need to be synced. That syncing part is the part I'd like insight on.

@ckipp01 ckipp01 marked this pull request as ready for review September 6, 2022 10:29
There are some legit cask failures when you bump. Plus it's
still on 0.10.5, so leave it as is
@ckipp01
Copy link
Member Author

ckipp01 commented Sep 6, 2022

@anatoliykmetyuk I got everything in staging updated as well since you gave your original ✅ . This should be good to merge, but just to make sure can you or someone else give a ✅ to verify.

Copy link
Contributor

@anatoliykmetyuk anatoliykmetyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@anatoliykmetyuk anatoliykmetyuk merged commit a503b7a into scala:main Sep 7, 2022
@ckipp01 ckipp01 deleted the millCommunity branch September 7, 2022 12:45
@anatoliykmetyuk
Copy link
Contributor

Regarding your original question: the most optimal way so far is to submit your work to the staging repo as a branch, and then update the submodule. Not the most ergonomic solution, but with the current setup, it does the job.

Sorry for the late reply – vacation period...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants