Skip to content

Cleanup BashExitCodeTests #15657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Jul 12, 2022

[test_windows_full]

@dwijnand dwijnand force-pushed the cleanup-BashExitCodeTests branch 2 times, most recently from 08cd4d6 to 5040d5f Compare July 15, 2022 07:30
@dwijnand dwijnand marked this pull request as ready for review July 15, 2022 07:46
@dwijnand dwijnand force-pushed the cleanup-BashExitCodeTests branch from 5040d5f to a827136 Compare July 15, 2022 10:04
@dwijnand dwijnand requested a review from rochala July 15, 2022 12:46
Copy link
Contributor

@rochala rochala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left 2 small comments. Otherwise the cleanup is a superb upgrade from original version.
LGTM

@dwijnand dwijnand force-pushed the cleanup-BashExitCodeTests branch from a827136 to a5966f9 Compare July 16, 2022 13:18
@dwijnand dwijnand enabled auto-merge July 16, 2022 13:18
@dwijnand dwijnand merged commit bb9c8ff into scala:main Jul 16, 2022
@dwijnand dwijnand deleted the cleanup-BashExitCodeTests branch July 16, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants