Small fixes to some warnings/comment typos #1565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixmulder
suggested changes
Oct 7, 2016
There was a problem hiding this comment.
Hi @Blaisorblade - thanks for taking the time to submit this PR.
Two things:
- Would you mind merging the first and last commit?
- Are you planning on reading more source code and correcting typos?
If 2, then I suggest we hold off on merging this until you've completed a sweep through the source code.
Cheers,
Felix
The warning is invalid but Scalac can't tell.
felixmulder
approved these changes
Oct 10, 2016
|
@Blaisorblade - let me know if you're still working on this. Otherwise we'd be happy to merge it :) |
|
Thanks—let me at least finish #1572, I might find more :-). I've also looked at other warnings but they're trickier. IIUC I could fix the ones about |
|
#1572's done, so go ahead! (No further time for now for this, too many deadlines coming). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just my 2 cents—things I noticed while taking a look at the architecture.