Harmonize PolyType and TypeLambda #1560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs to be rebased after the inline merge |
odersky
force-pushed
the
change-one-polytype
branch
from
777c309 to
0653344
Compare
|
Rebased to master |
odersky
force-pushed
the
change-one-polytype
branch
from
eb71034 to
c16cefb
Compare
|
In theory this commit paves the way to allow polymorphic types as value types. A test of some |
odersky
force-pushed
the
change-one-polytype
branch
from
6b0e68f to
d1cd209
Compare
smarter
force-pushed
the
change-one-polytype
branch
from
2ab3e5c to
bc786d7
Compare
Let them inherit the same traits and push as much functionality as possibly into the common superclass GenericType.
to account for the fact the GenericTypes are now TypeProxies.
Otherwise we can run into problems when checking imports for e.g. scala2Mode in later runs.
The refactored logic only applies to infos of denotations, not general types. The reactoring avoids special cases down the road then PolyTypes and MethodTypes can be used for terms as well as type(bounds).
If PolyTypes are to become value types we want to keep `=>` as the arrow for consistency. `->` should be reserved for PolyTypes that do not have side effects on instantiation.
smarter
force-pushed
the
change-one-polytype
branch
from
bc786d7 to
9e74d72
Compare
|
Rebased after the union-type PR merge |
|
LGTM, I wonder if we can merge |
Yes, interesting question. PolyParam is a reference to a parameter, whereas LambdaParam is a surrogate for a symbol, i.e. a definition. So it's not obvious, but still worth thinking about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push as much as we can into common superclass GenericType. Review by @smarter.
Update: I managed to completely eliminate any distinction between PolyType and TypeLambda. They are the same type now, and GenericType as a supertype could also be eliminated.