Don't report warnings in migration when performing rewrites #15589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechMazur
force-pushed
the
fix/no-warning-on-rewrite
branch
from
4a0646c to
08eb076
Compare
|
Hi, sorry this took so long, please could you rebase |
|
@bishabosha I think you can rebase on GitHub? |
WojciechMazur
force-pushed
the
fix/no-warning-on-rewrite
branch
from
08eb076 to
f8a7c5d
Compare
bishabosha
approved these changes
Mar 28, 2023
|
is this worth backporting? |
|
@odersky just checking if you object to this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops reporting migration warnings when the given code snippet is also being rewritten. It fixes terrible development experience when combining
-rewrite -source .*-migrationwith-Xfatal-warnings. In the mentioned case compilation would never succeed, since migration warnings elevated to errors, would always roll back generated rewrites.Since the warning message is not being shown in all paths I've changed the function arguments to be passed by name
Sidenote:
I've spent literally too much time wondering why -rewrites do not work as they should. I belive that typical Scala users would have the same problems.