Fix #1543: Add synthetic FunctionN types. #1553
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkDimius
reviewed
Oct 3, 2016
| @@ -753,7 +785,7 @@ class Definitions { | |||
| // ----- Initialization --------------------------------------------------- | |||
|
|
|||
| /** Lists core classes that don't have underlying bytecode, but are synthesized on-the-fly in every reflection universe */ | |||
| lazy val syntheticCoreClasses = List( | |||
| private lazy val syntheticCoreClasses = mutable.Set[Symbol]( | |||
There was a problem hiding this comment.
The order here matters, it should remain a List.
There was a problem hiding this comment.
Now it respects order again.
With this change it is possible to have create types for functions of any arity. This ensures that the compiler will not crash when creating FunProto when typing a method application method applications with more than MaxFunctionArity parameters. Note that in the language the functions are still bound to MaxFunctionArity, but this is a first small step towards supporting any function arity.
nicolasstucki
force-pushed
the
fix-1543
branch
from
20fa511 to
f9f8c25
Compare
|
How much work do you think would be required to remove the dependency on |
|
I'm not sure. I will try it again because it would be best to have a simple solution for this issue. |
|
I managed to find a trivial fix for this issue at the source of the problem. PR #1577 has this fix. This PR will become closed if the other one is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change it is possible to have create types for
functions of any arity. This ensures that the compiler will
not crash when creating FunProto when typing a method
application method applications with more than MaxFunctionArity
parameters. Note that in the language the functions are still
bound to MaxFunctionArity, but this is a first small step towards
supporting any function arity.