-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove obsolete note on escapes in interpolations #15450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9b13258
to
3ed03d3
Compare
The CI failure doesn't tell you where the link is referenced, but looking up the stack:
So grepping in |
@pikinier20 is this a no-brainer? I haven't followed whether there are changes in how docs are handled in scala 3. |
@Sporarum is this one you might be interesting in reopening and reviewing? |
@som-snytt I'm not very familiar with these escaping questions, could you clarify what you mean by
|
|
And from my tests, the behaviour is the same in Scala 3.2.0 Now the question, why was this PR closed ? |
"Closed for inactivity." |
Oh I see, I believe this would be valuable I see two options:
|
3ed03d3
to
38e38f0
Compare
@Sporarum I updated the page per your second suggestion, but I made it interesting instead of boring. It's worth advertising the behavior anyway. Also TIL "Quentin Bernet". Is a bernet the sort of beret they wear in Berne? |
I don't know if that is 99% by weight or volume. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me !
(I'm not 100% sure of the etymology of my name, but it seems indeed linked with the city of Bern, it might mean "from Bern" or something like that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh actually, we should maybe keep a part that explicitly mentions the old Scala 3 behaviour, again for the link's sake ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon further consideration, I think the raw
example should be included before this gets merged, to motivate the existence of the feature, and it's difference with the other way
Closing again because you're merging #16772 instead. Show some respect. |
@som-snytt can't tell if you're in earnest or not? I see some overlap between the two PRs, but not all that much. |
My point is that rebasing stale PRs is rock bottom contributor experience. "Use it or lose it." |
This would have been an appropriate section, perhaps, to document scala/bug#12789 rooted Edit: the have a spec version now, so the edit is at https://github.com/lampepfl/dotty/blob/main/docs/_spec/01-lexical-syntax.md |
As the spec is not ready to deploy yet, the focus should be on fixing the reference As such, I highly encourage you to reopen this PR which I believe to be valuable |
Scala 2/3 have parity on "how to escape double quote in an interpolated string with single-double quotes" since #11751
This commit fixes the Edison quotation (though I did not track down a source) and also adds a second bon mot which everyone knows from childhood, to illustrate both forms of escape. Google cites a source which cites the letter.
No links were harmed in the production of this PR.