Consider GADT upper bounds when upcasting the scrutinee type #15351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 172e957)
|
It seems that the CI tests are not executed for this PR. Is it possible to trigger it manually? |
abgruszecki
reviewed
Jun 7, 2022
There was a problem hiding this comment.
I think the logic should be closer to calling constrainPatternType with an intersection of the reconstructed/GADT upper bound with the super type. Something like:
tryConstrainSimplePatternType(pat, upcasted) && tryConstrainSimplePatternType(pat, upperGadtBound)
|| constrainUpcasted(upcasted)
Linyxus
reviewed
Jun 7, 2022
compiler/src/dotty/tools/dotc/core/PatternTypeConstrainer.scala
Outdated
Show resolved
Hide resolved
dwijnand
force-pushed
the
gadt/unapply-tuple-reasoning-upcast
branch
from
b0fe457 to
5c5189e
Compare
dwijnand
force-pushed
the
gadt/unapply-tuple-reasoning-upcast
branch
from
5c5189e to
1c3a286
Compare
abgruszecki
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 172e957)
[test_non_bootstrapped]