-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Change fewerbraces to always use a colon, even before lambdas #15273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f1d57c4
Predict self type instead of converting after the fact
odersky d64c6dc
Better prediction of formal parameters of lambdas
odersky 421bdd6
Change fewerBraces to always require colon
odersky a112f67
Update doc page
odersky c1f18cb
Tigthen lexical rules for ColonAtEOL
odersky d3670a6
Recognize fewer braces COLONeol's depending on previous token
odersky 69c4ad5
Remove side-effect in isColon
odersky 42eb08a
Make sure that fewerBraces as default will not work for 3.0-migration
odersky d3dd7dd
Apply suggestions from code review
odersky 2143474
Rename test
odersky 5b9b1a4
Allow colon lambdas as operands of infix operations
odersky d4ddbeb
Merge branch 'change-fewerbraces-1' of https://github.com/dotty-stagi…
odersky 32079ff
Restrict set of tokens after which a colon argument is allowed
odersky b1a6867
Updates to documentation
odersky 293f18c
Align treatment of `colon` in template bodies and arguments
odersky 143a0aa
Align the two synyax.md versions
odersky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -179,7 +179,7 @@ object JavaScanners { | |
nextChar() | ||
|
||
case ':' => | ||
token = COLON | ||
token = COLONop | ||
nextChar() | ||
|
||
case '@' => | ||
|
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.