Fix usage of outer type argument in extension inline unapply #15189
Conversation
…pe-argument # Conflicts: # compiler/src/dotty/tools/dotc/typer/Inliner.scala
|
@gorilskij I'm a bit confused. Is this a duplicate of #15191 fixing #15188 ? |
|
Somehow I managed to reproduce #15188 on the main branch even without #15191. |
| ${ implUnapplyD('ctx, 'input) } | ||
|
|
||
| // miscompilation | ||
| // val macroD"$xD" = 4 |
There was a problem hiding this comment.
If the intentional that this should not compile?
If so, you could create a separate netagive test in tests/neg/
| } | ||
| } | ||
|
|
||
| // { |
There was a problem hiding this comment.
Why is this section commented out?
|
@prolativ you're right, my bad, I thought initially it was dependent but it isn't. Even the code I posted in the issue has the same error with #15191 as without it. These are separate issues, only the test cases of #15189 depend on #15191. They probably should be merged, is there an easy way to do this or should I make a new PR for both? |
|
IMO you can just get all the code changes into one of the PRs and close the other |
|
Folded into #15191 |
Fixes #15191