Skip to content

Add redirections from old URLs to avoid breakages #15118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2022

Conversation

julienrf
Copy link
Contributor

@julienrf julienrf commented May 5, 2022

The Scala 3 reference documentation that used to be published to https://docs.scala-lang.org was using some different URLs than the URLs used by the documentation produced by Scaladoc. You can see here some examples of breakages:
scala/docs.scala-lang@763d518

We add redirects from previously supported URLs to avoid such breakages in case there are links in the web that point to the old URLs.

The Scala 3 reference documentation that used to be published to https://docs.scala-lang.org was using some different URLs than the URLs used by the documentation produced by Scaladoc. You can see here some examples of breakages:
scala/docs.scala-lang@763d518

We add redirects from previously supported URLs to avoid such breakages in case there are links in the web that point to the old URLs.
@julienrf julienrf requested a review from pikinier20 May 5, 2022 16:18
@@ -2,6 +2,7 @@
layout: index
title: "Other Changed Features"
movedTo: https://docs.scala-lang.org/scala3/reference/changed-features.html
redirectFrom: /changed-features.html
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I just realized that this is going to create an unexpected URL in the Dotty website (it should be /reference/changed-features.html in the Dotty website). Do you see a possible solution, @pikinier20?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In e17894e I propose an alternative implementation that alters only the content we publish to https://docs.scala-lang.org/scala3/reference.

@julienrf julienrf marked this pull request as draft May 5, 2022 16:20
@julienrf julienrf marked this pull request as ready for review May 6, 2022 06:55
@julienrf julienrf merged commit 8252ee6 into scala:language-reference-stable May 6, 2022
@julienrf julienrf deleted the add-aliases branch May 6, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants