Skip to content

Fix definition of task generateReferenceDocumentation #15076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

julienrf
Copy link
Contributor

It’s argument parser was missing a leading Space, making it awkward to invoke.

Furthermore, invocations of the tasks were not using the right (shell) syntax, this is why we didn’t notice the mistake so far.

It’s argument parser was missing a leading `Space`, making it awkward to invoke.

Furthermore, invocations of the tasks were not using the right (shell) syntax, this is why we didn’t notice the mistake so far.
@julienrf julienrf requested a review from pikinier20 April 29, 2022 15:27
@julienrf
Copy link
Contributor Author

The CI fails because it explicitly checks out the branch language-reference-stable instead of the PR branch.

@pikinier20
Copy link
Contributor

I agree, the CI will pass after merge

@julienrf julienrf merged commit e0e9e35 into scala:language-reference-stable May 4, 2022
@julienrf julienrf deleted the fix-generate-reference-documentation-task branch May 4, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants