Skip to content

Add tests checking whether the links haven't changed #14815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

pikinier20
Copy link
Contributor

This test is a response for the links problem that we had some time ago. Also, it might be useful for the language reference documentation that we want to deploy on docs.scala-lang.org since we can detect changed links after applying changes to documentation.

@pikinier20
Copy link
Contributor Author

@anatoliykmetyuk do you have any idea why the community build here is failing? I don't think I changed anything related to it.

@pikinier20 pikinier20 force-pushed the scaladoc/links-test branch from 43e18f5 to ff5115c Compare March 31, 2022 12:56
@bishabosha
Copy link
Member

seems like the community build failure was not deterministic?

@pikinier20
Copy link
Contributor Author

Yes, it was. That was strange since it failed 2 times and passed at third attempt

Copy link
Contributor

@romanowski romanowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if maybe we can use regenerateExectedLinks also in doscLinksSatbility? So we use only one mechanism to get the list of links?

@pikinier20 pikinier20 merged commit fdc31d2 into scala:main Apr 5, 2022
@pikinier20 pikinier20 deleted the scaladoc/links-test branch April 5, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants