-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Handle this prefix in classes (in quote patterns) #14800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
|
||
import scala.quoted.* | ||
import scala.tasty.inspector.Inspector | ||
import scala.tasty.inspector.Tasty | ||
import scala.tasty.inspector.TastyInspector | ||
import scala.reflect.ClassTag | ||
|
||
import scala.quoted.* | ||
import scala.tasty.inspector.* | ||
|
||
@main def Test: Unit = { | ||
// Artefact of the current test infrastructure | ||
// TODO improve infrastructure to avoid needing this code on each test | ||
val classpath = dotty.tools.dotc.util.ClasspathFromClassloader(this.getClass.getClassLoader).split(java.io.File.pathSeparator).find(_.contains("runWithCompiler")).get | ||
val allTastyFiles = dotty.tools.io.Path(classpath).walkFilter(_.extension == "tasty").map(_.toString).toList | ||
val tastyFiles = allTastyFiles.filter(_.contains("MySeq")) | ||
|
||
TastyInspector.inspectTastyFiles(tastyFiles)(new MyInspector) | ||
} | ||
|
||
class MySeq(override val length: Int) extends collection.Seq[String] { | ||
def foo: Int = length // error | ||
|
||
def apply(v1: Int): String = ??? | ||
def iterator: Iterator[String] = ??? | ||
} | ||
|
||
class MyInspector extends Inspector { | ||
def inspect(using Quotes)(tastys: List[Tasty[quotes.type]]): Unit = { | ||
import quotes.reflect.* | ||
val traverser = new TreeTraverser { | ||
override def traverseTree(tree: Tree)(owner: Symbol): Unit = { | ||
if (tree.isExpr) { | ||
try { | ||
tree.asExpr match { | ||
case '{ ($x: collection.Seq[t]).length } => | ||
super.traverseTree(tree)(owner) | ||
case _ => | ||
super.traverseTree(tree)(owner) | ||
} | ||
} catch { | ||
case e => | ||
report.error(s"unexpected error ${e}", tree.pos) | ||
throw e | ||
} | ||
} else { | ||
super.traverseTree(tree)(owner) | ||
} | ||
} | ||
} | ||
tastys.foreach{ tasty => | ||
traverser.traverseTree(tasty.ast)(tasty.ast.symbol) | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is patternHole special-cased now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the pattern does not contain a hole, then we do not need to extract a value and can just call
matched
directly. The code was updated to cover holes in any part of the prefix.