Skip to content

Remove postfixOps from dotty benchmark options #14685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

mbovel
Copy link
Member

@mbovel mbovel commented Mar 14, 2022

The option was removed from build settings in #14677. This PR also removes it from the dotty benchmark options.

@mbovel
Copy link
Member Author

mbovel commented Mar 14, 2022

test performance please

@dottybot
Copy link
Member

performance test scheduled: 5 job(s) in queue, 1 running.

@mbovel mbovel requested a review from anatoliykmetyuk March 14, 2022 15:00
@dottybot
Copy link
Member

Performance test finished successfully:

Visit https://dotty-bench.epfl.ch/14685/ to see the changes.

Benchmarks is based on merging with main (30ce9a5)

@@ -26,7 +26,7 @@ charts:

scripts:
dotty:
- measure -feature -deprecation -unchecked -Xfatal-warnings -encoding UTF8 -language:existentials,higherKinds,implicitConversions,postfixOps -Yexplicit-nulls -with-compiler $(find $PROG_HOME/dotty/compiler/src/dotty -name *.scala -o -name *.java)
- measure -feature -deprecation -unchecked -Xfatal-warnings -encoding UTF8 -language:existentials,higherKinds,implicitConversions -Yexplicit-nulls -with-compiler $(find $PROG_HOME/dotty/compiler/src/dotty -name *.scala -o -name *.java)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also remove existentials and higherKinds (here and in Build.scala) since they don't do anything in scala 3.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

higherKinds also does nothing in scala 2.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, I'm the one who silenced it :) scala/scala#8348

@mbovel
Copy link
Member Author

mbovel commented Mar 14, 2022

test performance please

@dottybot
Copy link
Member

performance test scheduled: 5 job(s) in queue, 1 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit https://dotty-bench.epfl.ch/14685/ to see the changes.

Benchmarks is based on merging with main (03d9ad1)

@smarter smarter marked this pull request as ready for review March 14, 2022 21:16
@smarter smarter merged commit fe7535f into scala:main Mar 14, 2022
@smarter smarter deleted the mb/dotty-bench-no-postfixOps branch March 14, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants