-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove postfixOps from dotty benchmark options #14685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove postfixOps from dotty benchmark options #14685
Conversation
test performance please |
performance test scheduled: 5 job(s) in queue, 1 running. |
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/14685/ to see the changes. Benchmarks is based on merging with main (30ce9a5) |
bench/profiles/projects.yml
Outdated
@@ -26,7 +26,7 @@ charts: | |||
|
|||
scripts: | |||
dotty: | |||
- measure -feature -deprecation -unchecked -Xfatal-warnings -encoding UTF8 -language:existentials,higherKinds,implicitConversions,postfixOps -Yexplicit-nulls -with-compiler $(find $PROG_HOME/dotty/compiler/src/dotty -name *.scala -o -name *.java) | |||
- measure -feature -deprecation -unchecked -Xfatal-warnings -encoding UTF8 -language:existentials,higherKinds,implicitConversions -Yexplicit-nulls -with-compiler $(find $PROG_HOME/dotty/compiler/src/dotty -name *.scala -o -name *.java) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also remove existentials and higherKinds (here and in Build.scala) since they don't do anything in scala 3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
higherKinds also does nothing in scala 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, I'm the one who silenced it :) scala/scala#8348
test performance please |
performance test scheduled: 5 job(s) in queue, 1 running. |
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/14685/ to see the changes. Benchmarks is based on merging with main (03d9ad1) |
The option was removed from build settings in #14677. This PR also removes it from the dotty benchmark options.