Improve documentation underlyingArgument
#14619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Mar 4, 2022
| * The resulting tree is useful for inspection of the value or content of a non-inline argument. | ||
| * | ||
| * Warning: This tree may contain references that are out of scope and should not be used in the generated code. | ||
| * This method should only used to port Scala 2 that used to access their outer scope unsoundly. |
There was a problem hiding this comment.
But it's safe to use this method for macros that don't splice the underlying argument anywhere, right?
Also, it'd be helpful to have an example showing what people should write instead of using underlying/underlyingArgument, because it's not clear to me.
There was a problem hiding this comment.
Also, it'd be helpful to have an example showing what people should write instead of using underlying/underlyingArgument, because it's not clear to me.
That is basically all the text in the macro tutorial related to inline arguments, value extraction and quote pattern matching.
smarter
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #14510