Skip to content

Publish back the release notes of 0.1.2 #14583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

julienrf
Copy link
Contributor

@julienrf julienrf commented Feb 28, 2022

The CI of the https://scala-lang.org website is failing because the page https://dotty.epfl.ch/docs/release-notes/0.1.2.html does not exist anymore.

This PR publishes back the page. However, there is a problem. My intention was to not include the page in the sidebar, yet I had to create an “empty” entry in the sidebar:

Screenshot from 2022-02-28 16-43-15

What we can do to solve this issue is either to support custom output path for pages, or to publish the page at the root of the website (https://dotty.epfl.ch/0.1.2.html) and update the link that points to it in scala/scala-lang#1346. Do you have any preference?

@julienrf julienrf requested a review from pikinier20 February 28, 2022 15:55
@pikinier20
Copy link
Contributor

You can add a redirectFrom in the root page, to redirect users from /release-notes/0.1.2.html to root documentation page

@pikinier20
Copy link
Contributor

But given that the release notes are no longer added to dotty website, we should probably change the links in scala-lang.org repo

@bishabosha
Copy link
Member

or can we remove the link from http://dotty.epfl.ch/blog/2017/05/31/first-dotty-milestone-release.html, it seems to be the only blog post referencing any release notes

@julienrf julienrf force-pushed the restore-old-release-notes branch from c2e4bb7 to 9db2eb5 Compare February 28, 2022 16:12
@julienrf
Copy link
Contributor Author

It’s good if we can keep it, it is also referenced by a blog post on scala-lang.org.

I tried using redirectFrom and it works fine, thank you for the tip! The only thing that is a little bit weird (but not blocking this specific PR) are the breadcrumbs:

Screenshot from 2022-02-28 17-12-07

How could I change them?

@julienrf julienrf marked this pull request as ready for review February 28, 2022 16:14
Copy link
Contributor

@pikinier20 pikinier20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's a way to change the breadcrumbs.

@julienrf julienrf merged commit 5a4a571 into scala:main Mar 1, 2022
@julienrf julienrf deleted the restore-old-release-notes branch March 1, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants