Fix safe-init error in DesugarEnums #14571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
requested review from
bishabosha and
liufengyun
and removed request for
bishabosha
bishabosha
reviewed
Feb 25, 2022
When bootstrapping the compiler with the `-Ysafe-init` flag, we would get the following error: ``` [error] -- Error: /Users/********/dotty/compiler/src/dotty/tools/dotc/ast/DesugarEnums.scala:20:39 [error] 20 | val Simple, Object, Class: Value = Value [error] | ^^^^^ [error] |Calling the external method method Value may cause initialization errors. ``` This error orginates from the Scala 2 `Enumeration` class definition. In order to circumvent this issue, we instead define `CaseKind` using a Scala 3 enum. While this does require enum comparisons using `<` or `<=` to explicitly compare the `ordinal` of the enum variant, it also eliminates the initialization error. Review by @liufengyun
Xavientois
force-pushed
the
safe-init-for-case-kind-enum
branch
from
12bf690 to
15ec5b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bootstrapping the compiler with the
-Ysafe-initflag, we wouldget the following error:
This error orginates from the Scala 2
Enumerationclass definition. In order to circumvent this issue, we instead defineCaseKindusing a Scala 3 enum. While this does require enum comparisons using<or<=to explicitly compare theordinalof the enum variant, it also eliminates the initialization error.Review by @liufengyun