Skip to content

Fix `sbt launchIDE' #14542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Fix `sbt launchIDE' #14542

merged 1 commit into from
Feb 22, 2022

Conversation

Jentsch
Copy link
Contributor

@Jentsch Jentsch commented Feb 22, 2022

vscode 1.1.36 tried to pull https://vscode-update.azurewebsites.net/api/releases/stable which isn't available anymore.

Triggered the migration to package-lock version 2.

Side question is launchIDE still used?

vscode 1.1.36 tried to pull https://vscode-update.azurewebsites.net/api/releases/stable which isn't available anymore.

Triggered the migration to package-log version 2.
@smarter
Copy link
Member

smarter commented Feb 22, 2022

Side question is launchIDE still used?

No, it was used to launch the dotty language server which was deprecated in favor of metals (https://scalameta.org/metals/)

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this is fine, but really we should just delete project/DottyIDEPlugin.scala and vscode-dotty/

@smarter smarter enabled auto-merge February 22, 2022 19:32
@Jentsch
Copy link
Contributor Author

Jentsch commented Feb 22, 2022

Side question is launchIDE still used?

No, it was used to launch the dotty language server which was deprecated in favor of metals (https://scalameta.org/metals/)

Thanks for the clarification.

@smarter smarter merged commit 48c65c4 into scala:main Feb 22, 2022
@Jentsch Jentsch deleted the master branch February 23, 2022 22:19
@SethTisue SethTisue mentioned this pull request Mar 1, 2022
@SethTisue
Copy link
Member

we should just delete project/DottyIDEPlugin.scala and vscode-dotty/

#14589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants