Fix #1443: Replace toplevel TypeBounds with Any #1450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cswinter
force-pushed
the
elim-toplevel-typebound
branch
from
f8ad4fe to
c201dec
Compare
| findWildcardType(t) match { | ||
| case Some(wildcardPos) => | ||
| syntaxError("unbound wildcard type", wildcardPos) | ||
| Select(Select(Ident(Names.termName("_root_")), Names.termName("scala")), |
There was a problem hiding this comment.
instead of Names.termName and Names.typeName you should use the names already defined in StdNames: nme.ROOTPKG, nme.scala_ and tpnme.Any.
There was a problem hiding this comment.
@cswinter Have a look at the definition of scalaUnit in untpd. I propose to model a scalaAny like this instead of writing things out in the parser.
|
/rebuild |
cswinter
force-pushed
the
elim-toplevel-typebound
branch
from
c201dec to
b029894
Compare
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a way to give a full path for "Any" that cannot be shadowed? I've not actually managed to come up with a situation where this would matter, but my current solution still seems inadequate.
Review by @smarter.