Fix: Weird Case Class Compiler Error with Inline Function #12508 #14476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…since boundSym is new, no need to use check in QuoteUtils.changeOwner)" This reverts commit 0241150 This might help fix scala#12508
tests/pos-macros/i11401/Main_2.scala
Outdated
| @@ -1,16 +0,0 @@ | |||
| package i11401 | |||
There was a problem hiding this comment.
This test should not be deleted
nicolasstucki
suggested changes
Feb 14, 2022
|
Revering this introduces more bugs. In the email, it was proposed as a quick workaround. |
|
@nicolasstucki I see you assigned yourself back to this. Is this something you still want to look into, or should we close? Maybe @qiujiangkun, you want to return to this? |
|
Sorry. I'm more busy than ever. Almost forgot about context |
No worries at all! It's been about a year of inactivity so I'll go ahead and close this. If either of you want to return to this, please do and reopen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert
fix #11401 (proxy parameter should be owned by proxy) (since boundSym is new, no need to use check in QuoteUtils.changeOwner)This reverts commit 0241150
This might help fix #12508
Seemingly fixes #12508, but I'm not sure what else it breaks. The new features are definitely missing
Proposed by
From: Nicolas Stucki <[email protected]>
Date: Mon, Jan 17, 2022 at 6:28 PM
Subject: Re: Building a tool on top of Dotty
To: Lionel Parreaux <[email protected]>
Cc: Martres Guillaume André Fradji <[email protected]>
A quick fix might be to revert 0241150 and publish it locally.
On Mon, 17 Jan 2022 at 02:47, Lionel Parreaux <[email protected]> wrote:
Salut Nico, (Cc Guillaume),
Un étudiant à moi essaie de construire une nouvelle approche pour spécialiser les programmes polymorphes, et on a décidé d'utiliser Dotty/Scala 3 comme base pour notre implémentation.
Malheureusement, on n'arrive pas à définir des classes polymorphes (crucial pour le projet) dans des macros à cause de Weird Case Class Compiler Error with Inline Function · Issue #12508 · lampepfl/dotty (github.com)
Donc on a essayé d'utiliser le Tasty Reader à la place, mais on se heurte maintenant à
Y a-t-il un moyen simple de contourner ces problèmes ? Ou une idée pour les résoudre directement dans le compilateur ?
Merci d'avance pour les conseils.
— LP