Skip to content

Fix safe-init error in MegaPhase #14464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions compiler/src/dotty/tools/dotc/transform/MegaPhase.scala
Original file line number Diff line number Diff line change
Expand Up @@ -455,11 +455,6 @@ class MegaPhase(val miniPhases: Array[MiniPhase]) extends Phase {

// Initialization code

for ((phase, idx) <- miniPhases.zipWithIndex) {
phase.superPhase = this
phase.idxInGroup = idx
}

/** Class#getDeclaredMethods is slow, so we cache its output */
private val clsMethodsCache = new java.util.IdentityHashMap[Class[?], Array[java.lang.reflect.Method]]

Expand Down Expand Up @@ -564,6 +559,11 @@ class MegaPhase(val miniPhases: Array[MiniPhase]) extends Phase {
private val nxOtherPrepPhase = init("prepareForOther")
private val nxOtherTransPhase = init("transformOther")

for ((phase, idx) <- miniPhases.zipWithIndex) {
phase.superPhase = this
phase.idxInGroup = idx
}

// Boilerplate snippets

def prepIdent(tree: Ident, start: Int)(using Context): Context = {
Expand Down