Fix #1372: Add handler for PatDefs to REPL
#1436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cswinter
force-pushed
the
wip-repl-patdef-fix
branch
from
df9080a to
2a17a7c
Compare
| s""" + $fullPath.toString() + "\\n" """ | ||
| } /* else */ { | ||
| "\"null\\n\"" | ||
| } | ||
| } |
There was a problem hiding this comment.
I find there are too many levels of escaping to be able to understand it. Can we try to put everything between one pair of """s and use only interpolation inside? That should also obviate the need for if_.
|
Otherwise LGTM |
cswinter
force-pushed
the
wip-repl-patdef-fix
branch
from
2a17a7c to
57f41f6
Compare
|
|
||
| val resultExtractors = | ||
| for (varName <- boundNames) | ||
| yield resultExtractionCode(req, varName) |
There was a problem hiding this comment.
val resultExtractors = boundNames.map(name => resultExtractionCode(req, name)) is more concise
cswinter
force-pushed
the
wip-repl-patdef-fix
branch
2 times, most recently
from
31cf7f1 to
17ba942
Compare
|
Thanks for making these changes, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new handler to
CompilingInterpreterto extract variable definitions fromPatDefstatements, which allows multiple assignment syntax and pattern match assignments to work properly in the REPL.Review by @odersky?