-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add special case to init checker to always allow certain methods #14352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
final class MyAsInstanceOfClass(o: MyAsInstanceOfClass) { | ||
val other: MyAsInstanceOfClass = { | ||
if (o.asInstanceOf[MyAsInstanceOfClass].oRef ne null) o // error | ||
else new MyAsInstanceOfClass(this) | ||
} | ||
val oRef = o | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
final class MyNeClass(o: MyNeClass) { | ||
val other: MyNeClass = { | ||
if (o ne null) o // o is cold, but ne is always valid | ||
else new MyNeClass(this) | ||
} | ||
} | ||
|
||
final class MyEqClass(o: MyEqClass) { | ||
val other: MyEqClass = { | ||
if (o eq null) new MyEqClass(this) // o is cold, but eq is always valid | ||
else o | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
final class MyIsInstanceOfClass(o: MyIsInstanceOfClass) { | ||
val other: MyIsInstanceOfClass = { | ||
if (!o.isInstanceOf[Object]) new MyIsInstanceOfClass(this) // o is cold, but isInstanceOf is always valid | ||
else o | ||
} | ||
} | ||
|
||
final class MyAsInstanceOfClass(o: MyAsInstanceOfClass) { | ||
val other: MyAsInstanceOfClass = { | ||
if (o.asInstanceOf[Object] ne null) o // o is cold, but ne and AsInstanceOf is always valid | ||
Xavientois marked this conversation as resolved.
Show resolved
Hide resolved
|
||
else new MyAsInstanceOfClass(this) | ||
} | ||
} | ||
|
||
final class MyAsInstanceOfFieldClass(o: MyAsInstanceOfFieldClass) { | ||
val oRef = o | ||
val other: MyAsInstanceOfFieldClass = { | ||
if (this.asInstanceOf[MyAsInstanceOfFieldClass].oRef ne null) oRef // o is cold, but ne and AsInstanceOf is always valid | ||
else new MyAsInstanceOfFieldClass(this) | ||
} | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.