Scala2Unpickler: Fix annotation argument handling #14334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an annotation argument is an Array, we can't know the element type of the Array until we've applied the argument to the annotation constructor, so we need to unpickle annotation arguments as untyped trees and rely on resolveConstructor to type them. This is the same logic we already use when unpickling Java classfiles since 610450f. Fixes scala#14223.
smarter
force-pushed
the
fix-scala2-arrayannotarg
branch
from
34de342 to
e43eb18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an annotation argument is an Array, we can't know the element type
of the Array until we've applied the argument to the annotation
constructor, so we need to unpickle annotation arguments as untyped
trees and rely on resolveConstructor to type them. This is the same
logic we already use when unpickling Java classfiles since
610450f.
Fixes #14223.