-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add forward compat tests for macros #14302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forward compat tests for macros #14302
Conversation
For |
725e71a
to
d4d077d
Compare
|
I reproduced it manually and got
Minimized in #14306 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general but shouldn't we actually swap the naming of forward/backward-compat tests? Generally when we test forward binary/TASTy compatibility we should check that the compilation output from a newer compiler can be consumed by an older compiler (which is the case if we add no compiler version suffix to the first file but we specify the older compiler for the second file)
No description provided.