Bump liqp to latest version #14238
Merged
Bump liqp to latest version #14238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
approved these changes
Jan 10, 2022
pikinier20
force-pushed
the
scaladoc/liqp-bump
branch
from
6976346 to
4040303
Compare
|
@pikinier20 On line 7 of file and Do we need to update it too ?! |
|
I've checked classpath of Scaladoc and the only jackson library that has 2.9.8 version is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3859
related to: #14235
I've generated Scala documentation and done some checking. Everything looks fine for me but it would be nice if somebody also checked some pages.