Fix using of wrong period for creating nested ctx in TreeTransforms #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to recurse in tree if there are no transformations left.
No need to perform zero transformations.
`owner` for nestedContext in `TreeTransforms` was assigned using initial period of whole `TreeTransforms` block. That is incorrect as denotation for this owner could have been create by some phase in this block.
DarkDimius
referenced
this pull request
in dotty-staging/dotty
Jul 16, 2014
because it violates a phase assumption of the micro phase framework. See class comment for details.
|
LGTM |
odersky
added a commit
that referenced
this pull request
Jul 17, 2014
Fix using of wrong period for creating nested ctx in TreeTransforms
WojciechMazur
pushed a commit
to WojciechMazur/dotty
that referenced
this pull request
Mar 19, 2025
Backport: Avoid using ExplainingTypeComparer in regular code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ownerfor nestedContext inTreeTransformswas assignedusing initial period of whole
TreeTransformsblock.That is incorrect as denotation for this owner could have been
create by some phase in this block and be non-existent at the initial period.