tests: Read tool args in test files #14144
Conversation
|
Forgot to say thanks for picking up this handy idiom. In return, I'm going to work on my ticket about test ignoring my options. |
dwijnand
force-pushed
the
tests/read-tool-args
branch
2 times, most recently
from
a6a0804 to
d6b01fe
Compare
dwijnand
force-pushed
the
tests/read-tool-args
branch
from
d6b01fe to
eb4b8cb
Compare
dwijnand
force-pushed
the
tests/read-tool-args
branch
from
eb4b8cb to
643314d
Compare
| @@ -58,7 +59,8 @@ def toolArgsParse(lines: List[String]): List[String] = { | |||
| val endc = "*" + "/" // be forgiving of /* scalac: ... */ | |||
| def stripped(s: String) = s.substring(s.indexOf(tag) + tag.length).stripSuffix(endc) | |||
| val args = lines.to(LazyList).take(10).filter { s => | |||
| s.contains("// " + tag) | |||
| s.contains("//" + tag) | |||
| || s.contains("// " + tag) | |||
| || s.contains("/* " + tag) | |||
There was a problem hiding this comment.
Should these also be accepted?
"// " + tagwith 2 or more spaces or a tab"/*" + tagwith no spaces
There was a problem hiding this comment.
Maybe we should consider a regex
There was a problem hiding this comment.
Less (ways) is more, IMO. I wouldn't have even added "/* ", but someone did back in scala/scala so I kept it.
There was a problem hiding this comment.
They're called s'mores for a reason. I see partest doesn't look at opening comment. Could filter on tag and then on open comment preceding it. As sample UX, I learned yesterday that commenting out an // error line does not suppress the error expectation. So temporarily commenting out requires two edits. My takeaway is that a test can be forgiving, but should help disallow "my check file was not used" or "my options were not used" and I didn't know it and the test has been broken all along.
No description provided.