Fix #1269: Typing and pattern matching of nested subclasses #1398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previously used `rebase` did not rewrire outer this references. The right thing to do here is an asSeenFrom.
Previous test did not reflect deeper paths for outer references. This caused a -Ycheck:patMat failure for i1269.scala.
|
/rebuild |
|
I'd like to review this PR. I'm currently relying on |
|
Is this ready to go in? It's been 2 weeks without any activity on this. |
|
@odersky, after applying this change in linker, the behavior did not change(I'm getting the same call graphs on tests), which is good. We need this change in for correctness though. So I propose to get the check in and discuss how we can get the speed back later. LGTM. |
|
Interesting that the running time went up so much. There might be some scope for caching asSeenFroms, similar to what we do for caching member denotations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two problems, one in typing and one in pattern matching were fixed.
Review by @liufengyun or @DarkDimius.