Skip to content

Transform/super accessors #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jul 1, 2014

Added superaccessor transform.

@odersky
Copy link
Contributor Author

odersky commented Jul 1, 2014

Needs higher-kinded to go in first, because the earlier commits are based on it. The first commit
of this PR propwe is "Add cloneScope method...".

odersky added 9 commits July 10, 2014 17:08
This is done to streamline changing class denotations in new phases
by adding to (or otherwise modifying) their decls scope.
Should do the same with other name-creator/name-test pairs.
Added the following utility methods:

 - polyDefDef: Create a DefDef given a function that takes type and value parameters and yields a body.
 - appliedToTypeTrees: Apply function to type arguments ion a TypeApply if arguments are nonempty.
 - mkAsInstanceOf
 - ensureConforms: generate a cast if expression has non-conforming type.
Added this case, so that .symbol on a ThisType returns the underlying class.
(1) Make sure ModifierFlags is TermFlags and TypeFlags
(2) Shorten private <local> to private[this]; same with protected
(3) Print [this] for local symbols in RefinedPrinter
Rewrote SuperAccessors (more to be done; see comments), and
added stuff here and there to make it work smoother.
... for the common supertype of MethodType, PolyType, and ExprType.
Signed was confusing.
@odersky
Copy link
Contributor Author

odersky commented Jul 10, 2014

Force pushed after rebasing to current master. This forms the first part of PR #140

@DarkDimius
Copy link
Contributor

Merged as part of #140

@DarkDimius DarkDimius closed this Jul 17, 2014
WojciechMazur pushed a commit to WojciechMazur/dotty that referenced this pull request Mar 19, 2025
Backport "Bump webrick from 1.8.2 to 1.9.1 in /docs/_spec" to 3.3 LTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants