Change Untyped from Null to Nothing for Trees #13883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
approved these changes
Nov 5, 2021
|
I restarted the stalled Windows test |
|
@odersky Is the CI test broken? It still says: "Can't find any online and idle self-hosted runner in the current repository, account/organization that matches the required labels: 'self-hosted , Windows' |
|
Looks like it. it was acting up lately.
…On Fri, Nov 5, 2021 at 7:13 PM noti0na1 ***@***.***> wrote:
@odersky <https://github.com/odersky> Is the CI test broken? It still
says: "Can't find any online and idle self-hosted runner in the current
repository, account/organization that matches the required labels:
'self-hosted , Windows'
Waiting for a self-hosted runner to pickup this job..."
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13883 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGCKVRBU776KXH4MQ5QMB3UKQUEPANCNFSM5HNDT7NQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Martin Odersky
Professor, Programming Methods Group (LAMP)
Faculty IC, EPFL
Station 14, Lausanne, Switzerland
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untyped = Nothingis a more logical choise forTrees, since an untyped tree should not have any value for its type.This change will also make migration to explicit-nulls more easy (the type bound
Untyped <:< Typebecomes valid).I don't notice any compiling error after I change the definition of
Untypedtype, so I guess the inference issue mentioned in the comment has been solved? @odersky