Remove cruft from TyperPhase #13771
Remove cruft from TyperPhase #13771
Conversation
More unused.
| @@ -89,11 +73,9 @@ class TyperPhase(addRootImports: Boolean = true) extends Phase { | |||
| else | |||
| newCtx | |||
|
|
|||
| remaining = unitContexts | |||
| while remaining.nonEmpty do | |||
There was a problem hiding this comment.
this while loop was probably added for a performance critical reason, I suggest remaining could be made a local variable (maybe premature optimisation?)
There was a problem hiding this comment.
I’m pretty sure it was there to enable stillToBeEntered, which is no longer used (AFAICT).
There was a problem hiding this comment.
Friendly ping @bishabosha? Is there anything I need to change here?
There was a problem hiding this comment.
Im running the benchmarks, I'm sure that it probably makes no difference if it is foreach or a loop
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/13771/ to see the changes. Benchmarks is based on merging with master (968dd1b) |
|
Thanks! |
During development of #13762, I noticed there was some defunct code in the TyperPhase. This PR (the first commit of the previous PR) cleans up that cruft.