Trial: Test performance #13715
Closed
Trial: Test performance #13715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it closer to the Scala Symposium 21 paper.
Otherwise, the symbol denotations are not update to date: some synthetic members are missing, thus static method resolution produces incorrect result.
This is important because we don't revert the heap on error. Therefore, the stable cache has to be updated. Otherwise, a warm object might be initialized twice, violating invariants.
Two motivations: First, it's close to the essence of its functionality. Second, it's easier to update the cache state in fixed-pointed computation.
The following test explodes: tests/init/pos/local-warm5.scala. Ideally we should use an actual set in RefSet, which we don't do for both performance and determinism. The performance concern might be a premature optimization.
Use correct klass for evaluating rhs of local variables.
Co-authored-by: Ondřej Lhoták <[email protected]> Co-authored-by: Natsu Kagami <[email protected]>
|
test performance please |
|
@anatoliykmetyuk It seems the bot is not working? |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/13715/ to see the changes. Benchmarks is based on merging with master (1ed25ce) |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/13715/ to see the changes. Benchmarks is based on merging with master (1ed25ce) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trial: Test performance
[skip-ci]