Skip to content

Fix #1366: constant adaptation #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2016
Merged

Fix #1366: constant adaptation #1371

merged 2 commits into from
Jul 11, 2016

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jul 8, 2016 •
edited
Loading

Fix #1366: Constant adaptation did not work if the
expected type was an as yet uninstantiated type variable.

Review by @nicolasstucki

@odersky
Fix: scala#1366, constant adaptation
bcf6354 
Fix: scala#1366. Constant adaptation did not work if the
expected type was an as yet uninstantiated type variable.
@nicolasstucki
Copy link
Contributor

@odersky should probably add ('a', 98): (Char, Char) in pos test.

@odersky
Copy link
Contributor Author

odersky commented Jul 8, 2016

@nicolasstucki Good point, I had forgotten to push the test.

@nicolasstucki
Copy link
Contributor

By the way the format for the commits with fixes is Fix #1366: ...

@odersky
Copy link
Contributor Author

odersky commented Jul 8, 2016

Ah OK. I'll change it then.

On Fri, Jul 8, 2016 at 3:51 PM, Nicolas Stucki [email protected]
wrote:

By the way the format for the commits with fixes is Fix #1366: ...

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1371 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAwlVjl-T3KKWYNKYmt1WaOeIL86_Cgeks5qTlXHgaJpZM4JICZS
.

Prof. Martin Odersky
LAMP/IC, EPFL

@odersky odersky changed the title Fix: #1366, constant adaptation Fix #1366: constant adaptation Jul 8, 2016
@nicolasstucki
Copy link
Contributor

Just double checked with this fix on the code from scalacheck where I found the bug and the errors for this are gone.

@odersky
Copy link
Contributor Author

odersky commented Jul 9, 2016

OK, I assume ready to merge then?

@nicolasstucki
Copy link
Contributor

LGTM

@nicolasstucki nicolasstucki merged commit 6ca5b9d into scala:master Jul 11, 2016
@nicolasstucki nicolasstucki mentioned this pull request Jul 11, 2016
Closed
@allanrenucci allanrenucci deleted the fix-#1366 branch December 14, 2017 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@odersky @nicolasstucki @felixmulder @dottybot